-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gctcli: Fix enable flag for various commands #752
Conversation
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 42.89% 42.92% +0.02%
==========================================
Files 306 306
Lines 77389 77389
==========================================
+ Hits 33198 33218 +20
+ Misses 39300 39276 -24
- Partials 4891 4895 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Thanks for the fix! Tested on master
and here.
It has revealed an issue with curreny pair syncer though with enableall
at least with Bittrex Bittrex spot XDC-EUR exchange currency pair syncer not found
. disableall
is similarly broken, but its outside of scope of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK - Also revealed an issue with the websocket manager but this is out of scope:
❯ go run ./... websocket disable binance
{
"status": "success",
"data": "websocket disabled"
}
❯ go run ./... websocket enable binance
2021/08/18 08:43:29 rpc error: code = Unknown desc = websocket is already enabled for exchange Binance
exit status 1
Related to: #737 |
PR Description
Fix enable flag for various gctcli commands
Fixes #751
Type of change
How has this been tested
Checklist