Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gctcli: Fix enable flag for various commands #752

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

thrasher-
Copy link
Collaborator

PR Description

Fix enable flag for various gctcli commands

Fixes #751

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested

  • go test ./... -race
  • golangci-lint run
  • below command
$ ./gctcli pair enable --exchange binance --pairs "VITE-BTC" --asset spot
{
 "status": "success"
}

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Github Actions/AppVeyor with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #752 (8406e73) into master (c38757a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #752      +/-   ##
==========================================
+ Coverage   42.89%   42.92%   +0.02%     
==========================================
  Files         306      306              
  Lines       77389    77389              
==========================================
+ Hits        33198    33218      +20     
+ Misses      39300    39276      -24     
- Partials     4891     4895       +4     
Impacted Files Coverage Δ
database/models/postgres/script.go 37.88% <0.00%> (-1.16%) ⬇️
exchanges/ftx/ftx_wrapper.go 29.43% <0.00%> (+0.13%) ⬆️
engine/datahistory_manager.go 68.26% <0.00%> (+0.29%) ⬆️
exchanges/lbank/lbank_wrapper.go 31.02% <0.00%> (+0.33%) ⬆️
database/models/postgres/audit_event.go 50.86% <0.00%> (+1.48%) ⬆️
exchanges/bitmex/bitmex_wrapper.go 42.25% <0.00%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38757a...8406e73. Read the comment docs.

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Thanks for the fix! Tested on master and here.

It has revealed an issue with curreny pair syncer though with enableall at least with Bittrex Bittrex spot XDC-EUR exchange currency pair syncer not found. disableall is similarly broken, but its outside of scope of this

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK - Also revealed an issue with the websocket manager but this is out of scope:

❯ go run ./... websocket disable binance
{
 "status": "success",
 "data": "websocket disabled"
}

❯ go run ./... websocket enable binance
2021/08/18 08:43:29 rpc error: code = Unknown desc = websocket is already enabled for exchange Binance
exit status 1

@thrasher-
Copy link
Collaborator Author

tACK - Also revealed an issue with the websocket manager but this is out of scope:

❯ go run ./... websocket disable binance
{
 "status": "success",
 "data": "websocket disabled"
}

❯ go run ./... websocket enable binance
2021/08/18 08:43:29 rpc error: code = Unknown desc = websocket is already enabled for exchange Binance
exit status 1

Related to: #737

@thrasher- thrasher- merged commit 08df015 into thrasher-corp:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC 'pair enable' doesn't pass 'enable' bool flag
3 participants