Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/compute_neighbors, issue #1212 #1229

Closed
wants to merge 1 commit into from

Conversation

Abelgurung
Copy link

#1212
scv.pp.moments(adata, n_pcs= int , n_neighbors= int )

Returns:
TypeError: Neighbors.compute_neighbors() got an unexpected keyword argument 'write_knn_indices'

The argument write_knn_indices was deprecated in a previous commit (see scanpy commit 1fd6c46)

Removing 'write_knn_indices' arg from the compute_neighbors method call within scv.pp.moments does not seem to affect downstream analysis
Lmk what you think @WeilerP

@WeilerP
Copy link
Member

WeilerP commented Apr 12, 2024

Thanks, @Abelgurung. I'm closing this PR in favor of #1233. Please use the provided template and check unit tests locally when submitting a PR next time.

@WeilerP WeilerP closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants