Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GHA workflow #55

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add GHA workflow #55

merged 1 commit into from
Jul 17, 2024

Conversation

archanaserver
Copy link
Contributor

No description provided.

adamruzicka
adamruzicka requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with having the rubocop part of this

.github/workflows/ci_test.yml Outdated Show resolved Hide resolved
@archanaserver
Copy link
Contributor Author

I'd be fine with having the rubocop part of this

This make sense, I just dropped the other part. Thanks @adamruzicka.

@adamruzicka adamruzicka merged commit e336fca into theforeman:master Jul 17, 2024
4 checks passed
@adamruzicka
Copy link
Contributor

Thank you @archanaserver !

@archanaserver archanaserver deleted the gha branch July 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
RuboCop upgrade
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archanaserver @adamruzicka