Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46. Rt tailwindcss and reacticons #46

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

GrannyYetta
Copy link
Collaborator

Description

The code now includes the base for the styling. Icons and fonts have been added and tailwind css has been initalized.

Related Issue

closes #36

Acceptance Criteria

  • Add the following icons:
    • One for Manage List
    • One for List
    • One for Home
    • One for About
    • One for the logo
  • Include the fonts to be used by the app
  • Initialize TailwindCSS installation
    • Create tailwind.config.js file in the project root directory.

Type of Changes

Layout.jsx

In the navigation, react icons were added to their respective terms in the navigation ("Home", "List", "Manage List" and "About").

Additionally, the tab no longer shows the react icon, but a shopping cart icon.

index.css

The Tailwind directives were added to the main CSS file.

Tailwind, PostCSS and Autoprefixer packages were installed and initialized, so that tailwind.config.js and postcss.config.js files were added to the root folder.

Updates

Before

Captura de pantalla 2024-09-29 a la(s) 15 17 27

Captura de pantalla 2024-09-29 a la(s) 15 17 18

Captura de pantalla 2024-09-29 a la(s) 15 17 13

After

Captura de pantalla 2024-09-29 a la(s) 15 18 29

Captura de pantalla 2024-09-29 a la(s) 15 18 36

Captura de pantalla 2024-09-29 a la(s) 15 18 42

Testing Steps / QA Criteria

  • npm start
  • Click on the navigation icons

Copy link

Visit the preview URL for this PR (updated for commit fe913d4):

https://tcl-78-smart-shopping-list--pr46-rt-tailwindcss-and-r-svcvd0ks.web.app

(expires Sun, 06 Oct 2024 13:20:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@didemydn didemydn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Becka, on my side eveything is fine. besides I like the app name Shop'nGo

Copy link
Collaborator

@Amaka202 Amaka202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!💥

Comment on lines +14 to +19
<link
rel="icon"
type="image/svg+xml"
href="/img/noun-shopping-cart-3972679.png"
/>
<title>Shop'n Go</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job here!

@GrannyYetta GrannyYetta changed the title Rt tailwindcss and reacticons 46. Rt tailwindcss and reacticons Oct 2, 2024
@GrannyYetta GrannyYetta merged commit 2c3f8d2 into main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants