Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add general styles 23 #49

Merged
merged 7 commits into from
Oct 2, 2024
Merged

add general styles 23 #49

merged 7 commits into from
Oct 2, 2024

Conversation

sar-mko
Copy link
Collaborator

@sar-mko sar-mko commented Sep 30, 2024

Description

  • Imported Tailwind.CSS
  • Imported DaisyUI
  • Imported Archivo Narrow font
  • Added Lemonade and Coffee as themes in the tailwind.config file
  • Added font-archivo in home.jsx as a preview

Related Issue

closes #42 (#23)

Acceptance Criteria

  • Colors and fonts are established and are consistent across pages
  • There is a dark mode toggle that a user can activate to change the display of our app

Type of Changes

enhancement

Updates

After

Screenshot 2024-09-30 at 12 42 47 PM

Testing Steps / QA Criteria

  • install new packages with npm i / npm install
  • Should be able to add Archivo font as font-archivo as a class for specific elements as see the font difference. Right now it is only in Home.jsx added as a class on the ul for the list of lists.
  • Should see a lemon yellow background on all pages

Copy link

github-actions bot commented Sep 30, 2024

Visit the preview URL for this PR (updated for commit cf733e5):

https://tcl-76-smart-shopping-list--pr49-sm-add-general-style-k5c0hxe8.web.app

(expires Wed, 09 Oct 2024 16:34:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

Copy link
Collaborator

@arandel1 arandel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!
small blocker: Needed to run npm i to get app to load on localhost. Need to make sure all dependencies are available.
nit-pick/non-blocking: Buttons and headings aren't styled. Curious what we think about merging this branch as it is, or if we should get buttons and headers styled before merging.

@mentalcaries
Copy link
Collaborator

Nice!! small blocker: Needed to run npm i to get app to load on localhost. Need to make sure all dependencies are available. nit-pick/non-blocking: Buttons and headings aren't styled. Curious what we think about merging this branch as it is, or if we should get buttons and headers styled before merging.

Definitely a nice start. Do you have some general/global styles for those headings and buttons? If so I think you can set and merge those in, and then dial them in as you start going through the components

Copy link
Collaborator

@EmmaBin EmmaBin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the color and font changes. I agree with the idea of implementing a global style for the heading font and button styles to have a consistency across all pages.

@sar-mko sar-mko merged commit 64ce84a into main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

23. As a user, I want an app that has a clean and simple design
4 participants