Skip to content

Commit

Permalink
feat: fall back default builder to buildkit-container (#1548)
Browse files Browse the repository at this point in the history
* feat: fall back default builder to buildkit-container

Signed-off-by: Kaiyang-Chen <kaiyang-chen@sjtu.edu.cn>

* feat: fall back default builder to buildkit-container

Signed-off-by: Kaiyang-Chen <kaiyang-chen@sjtu.edu.cn>

---------

Signed-off-by: Kaiyang-Chen <kaiyang-chen@sjtu.edu.cn>
  • Loading branch information
Kaiyang-Chen committed Mar 30, 2023
1 parent 1f547f9 commit 04f43da
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions pkg/home/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"github.com/cockroachdb/errors"
"github.com/sirupsen/logrus"

"github.com/tensorchord/envd/pkg/driver/docker"
sshconfig "github.com/tensorchord/envd/pkg/ssh/config"
"github.com/tensorchord/envd/pkg/types"
)
Expand Down Expand Up @@ -54,11 +53,6 @@ var (
)

func Initialize() error {
builder := types.BuilderTypeDocker
dockerVersion, err := docker.GetDockerVersion()
if err == nil && dockerVersion > 22 {
builder = types.BuilderTypeMoby
}
once.Do(func() {
defaultManager = &generalManager{
cacheMap: make(map[string]bool),
Expand All @@ -67,7 +61,7 @@ func Initialize() error {
Contexts: []types.Context{
{
Name: "default",
Builder: builder,
Builder: types.BuilderTypeDocker,
BuilderAddress: "envd_buildkitd",
Runner: types.RunnerTypeDocker,
RunnerAddress: nil,
Expand Down

0 comments on commit 04f43da

Please sign in to comment.