Support container provisioner in toolbox #3228
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Fedora Silverblue users it is common to run podman via `flatpak-spawn --host` which runs podman on the host system itself. This requires to pass the toolbox container name when running `podman cp` to correctly copy stuff from the toolbox container, where `tmt` is installed to the provisioned container. Fixes #1020 Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
|
@jkonecny12 this is the change I talked about, with it tmt container provisioner works well :) |
happz
reviewed
Sep 20, 2024
| if line.startswith('name="'): | ||
| return line[6:-1] | ||
|
|
||
| return None |
There was a problem hiding this comment.
These two look like they belong to guest facts, as they are properties of a machine similar to has_selinux or arch, for example. Once moved, you would reach them via self.parent.plan.my_run.runner.facts.*.
There was a problem hiding this comment.
thanks for the pointers
happz
reviewed
Sep 20, 2024
| @functools.cached_property | ||
| def _is_toolbox(self) -> bool: | ||
| """ Return ``True`` if running in toolbox, ``False`` otherwise. """ | ||
| if os.path.exists('/run/.toolboxenv'): |
There was a problem hiding this comment.
os.path should be replaced with Path().exists()
There was a problem hiding this comment.
need to remember we use pathlib here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Fedora Silverblue users it is common to run podman via
flatpak-spawn --hostwhich runs podman on the host system itself. This requires to pass the toolbox container name when runningpodman cpto correctly copy stuff from the toolbox container, wheretmtis installed to the provisioned container.Fixes #1020
Pull Request Checklist