Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position of hardware filter in mrack request #3211

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix position of hardware filter in mrack request #3211

merged 1 commit into from
Sep 18, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 12, 2024

This was broken in 1.36.0, therefore HW requirements were ignored.

Pull Request Checklist

  • implement the feature

@happz happz added bug Something isn't working step | provision Stuff related to the provision step area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin labels Sep 12, 2024
@happz happz added this to the 1.37 milestone Sep 12, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Sep 12, 2024
@happz happz added the code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. label Sep 16, 2024
psss
psss approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@psss psss changed the title Fix position of HW filter in mrack request Fix position of hardware filter in mrack request Sep 17, 2024
@psss psss changed the title Fix position of hardware filter in mrack request Fix position of hardware filter in mrack request Sep 17, 2024
@psss psss force-pushed the beaker-hw-requirements-in-wrong-key branch 2 times, most recently from f343ab3 to 38c1b55 Compare September 17, 2024 11:14
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 17, 2024
@happz
Fix position of hardware filter in mrack request
386d122 
This was broken in 1.36.0, therefore HW requirements were ignored.
@happz happz force-pushed the beaker-hw-requirements-in-wrong-key branch from 38c1b55 to 386d122 Compare September 17, 2024 13:22
@happz happz merged commit 2bef9dd into main Sep 18, 2024
22 checks passed
@happz happz deleted the beaker-hw-requirements-in-wrong-key branch September 18, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@therazix therazix therazix approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual dav-pascual is a code owner

@thrix thrix Awaiting requested review from thrix

@lukaszachy lukaszachy Awaiting requested review from lukaszachy

Assignees
No one assigned
Labels
area | hardware Implementation of hardware requirements bug Something isn't working ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. plugin | mrack The beaker provision plugin status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @psss @therazix