Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo & create-svelte-ux #119

Merged
merged 29 commits into from
Nov 10, 2023
Merged

monorepo & create-svelte-ux #119

merged 29 commits into from
Nov 10, 2023

Conversation

jycouet
Copy link
Collaborator

@jycouet jycouet commented Nov 9, 2023

No description provided.

Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: bd9b71f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-ux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 5:07pm

Copy link
Owner

@techniq techniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review while I had a minute. I'll pull it locally hopefully tonight and kick it around. I know the Vercel build is failing...

image

I'm figuring I can just set the Root Directory to packages/svelte-ux to resolve (or similar).

image

LICENSE Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/create-svelte-ux/bin.js Outdated Show resolved Hide resolved
packages/create-svelte-ux/bin.js Outdated Show resolved Hide resolved
packages/create-svelte-ux/bin.js Outdated Show resolved Hide resolved
packages/create-svelte-ux/package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@techniq
Copy link
Owner

techniq commented Nov 10, 2023

Quick review while I had a minute. I'll pull it locally hopefully tonight and kick it around. I know the Vercel build is failing...

image

I'm figuring I can just set the Root Directory to packages/svelte-ux to resolve (or similar).

image

build fixed

image

@jycouet jycouet marked this pull request as ready for review November 10, 2023 17:03
@techniq techniq merged commit fd15540 into techniq:master Nov 10, 2023
3 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants