Fix scrolling away when opening menu (#400)

techniq · Jun 20, 2024 · 47f4685 · 47f4685
1 parent 1013e24
commit 47f4685
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/swift-paws-dance.md b/.changeset/swift-paws-dance.md
@@ -0,0 +1,5 @@
+---
+"svelte-ux": patch
+---
+
+Fix scrolling away when opening menu
diff --git a/packages/svelte-ux/src/lib/actions/focus.ts b/packages/svelte-ux/src/lib/actions/focus.ts
@@ -1,5 +1,5 @@
-import { tick } from 'svelte';
 import type { ActionReturn } from 'svelte/action';
+import { delay } from '$lib/utils/promise.js';
 
 export function focusMove(
   node: HTMLElement,
@@ -14,7 +14,7 @@ export function focusMove(
     // Set `tabIndex` to `-1` which makes any element (ex. div) focusable programmaitcally (and mouse), but not via keyboard navigation - https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex
     node.tabIndex = -1;
     // Appear to need to wait for tabIndex to update before applying focus
-    tick().then(() => {
+    delay(0).then(() => {
       node.focus();
     });