unit-testing and general improvements. #29

h4rldev · 2024-08-11T04:48:01Z

This pr has these TODOs before I'm comfortable with review:

- "Complete" Unit-Testing support, for testing all components of this project.
- Add a script to integrate a set version of Unity into it instead of including the files into the repo.
- Proper execution, with execve instead for more control.
- Properly introduce builtins.

…nges to almost all files (i don't remember what I changed tbh), but I did finally unsterstand how strlcat works, and I also managed to get builtins working, will work on how they're called though in the future.

.github/workflows/ci.yml

scripts/build.sh

.github/workflows/ci.yml

src/hamon/exec.c

src/main.c

test/test_escape.c

.github/workflows/ci.yml

Signed-off-by: h4rl <98224660+h4rldev@users.noreply.github.com>

README.md

…'s own repo

…gc flushing, implemented full testing for builtins, aswell as new builtins, such as pwd and cd.

src/hamon/builtins.c

test/test_builtins.c

…ite and finish test_cli

…ing, fixed some bugs with certain functions.

github-advanced-security

Flawfinder (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

src/hamon/builtins.c

src/hamon/prompt.c

src/hamon/builtins.c

.github/workflows/ci.yml

tests/test_escape.c

…tructure.

h4rldev · 2024-09-05T22:22:41Z

@Intancote. All I'm missing is the review, then I can focus on a better tokenizer and proper windows support (I just set up a windows vm for this purpose)

github-advanced-security · 2024-09-06T06:10:47Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

src/hamon/prompt.c

README.md

@Intancote

…il this pr has been merged. @Intancote

build/build.sh

src/hamon/cli.c

src/hamon/file.c

Intancote

Although some parts could be improved, these can be addressed later.
For now, this is a massive improvement over the current main branch. Further work will be done outside of the PR of course, and a 'functional' version for Windows will be added later on.
For now, this PR is approved 👍
All that needs to be done before the merge is for all checks too pass.

src/hamon/prompt.c

+  while (*ptr != '\0' && count < 4096 - 1) {
+    size_t len = strlen(ptr);
+    env_array[count] = malloc(len + 1);
+    strlcpy(env_array[count], ptr, strlen(env_array[count]) + 1);


…ng and writing in binary mode is unneeded.

Intancote

Same as my last review, but now all checks are good 👍

intro(test & hamon): Begin implementing unit tests, make some big cha…

723d37e

…nges to almost all files (i don't remember what I changed tbh), but I did finally unsterstand how strlcat works, and I also managed to get builtins working, will work on how they're called though in the future.

h4rldev added enhancement New feature or request help wanted Extra attention is needed dependencies Pull requests that update a dependency file labels Aug 11, 2024

h4rldev assigned h4rldev and Intancote Aug 11, 2024

h4rldev requested a review from Intancote August 11, 2024 04:48