feat: add query complexity and depth support in server directive #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2828 +/- ##
==========================================
+ Coverage 87.13% 87.27% +0.14%
==========================================
Files 254 257 +3
Lines 25144 25343 +199
==========================================
+ Hits 21910 22119 +209
+ Misses 3234 3224 -10 ☔ View full report in Codecov by Sentry. |
laststylebender14
changed the title
tusharmath
reviewed
Sep 21, 2024
| .when(self.index.query_depth().is_some()), | ||
| ) | ||
| .validate(&plan) | ||
| .to_result()?; |
There was a problem hiding this comment.
Store the computed query depth in the plan. The builder should not fail if depth or complexity thresholds are exceeded.
tusharmath
reviewed
Sep 21, 2024
| } | ||
| } | ||
|
|
||
| impl ExecutionRule for QueryDepth { |
There was a problem hiding this comment.
ExecutionRule is basically Transform with Value = OperationPlan and Error = String. Let's reuse it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
documentation update pull request: tailcallhq/tailcallhq.github.io#492
Issue Reference(s):
Fixes #2725
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>