fix: force wallet refresh after onchain tx broadcasted #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limpbrains
force-pushed
the
force-wallet-refresh
branch
from
04a62d9
to
41df393
Compare
|
If I understand correctly this issue is still there: Simulator.Screen.Recording.-.iPhone.15.-.2024-09-11.at.13.39.59.mp4 |
limpbrains
force-pushed
the
force-wallet-refresh
branch
from
41df393
to
1dad0a8
Compare
limpbrains
force-pushed
the
force-wallet-refresh
branch
from
1dad0a8
to
1daf256
Compare
|
New version with refresh after boost broadcast, can you please try it |
|
Still running into to this: Simulator.Screen.Recording.-.iPhone.15.-.2024-09-11.at.14.02.37.mp4Also after boosting with RBF the balance is briefly set to 0: Simulator.Screen.Recording.-.iPhone.15.-.2024-09-11.at.14.04.06.mp4 |
|
Codewise this feels like this logic needs to be in a central place (probably beignet) instead of being spread out in multiple places. UTXO state should be always 'fresh', maybe after EDIT: I think if the automatic update fails it needs to try again |
|
I agree there should be a better way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normally beignet listens to the wallet addresses and automatically starts the update. But just in case subscription failed, run it manually. It will not hurt, since the refreshWallet method is protected by a Promise and can't be run twice at the same time
This should prevent errors when wallet tries to use UTXOs that is already spent
Linked Issues/Tasks
Type of change
Bug fix
Tests
No test
Screenshot / Video
QA Notes
Try to make 2 transactions quickly