Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removeUnusedPeers was added a few years back to avoid connecting to peers that wallet did not have a channel with or was not a Blocktank node. On restore this was being triggered before syncing channels with redux state so it was removing peers before realising there was actually an active channel.
I think auto dropping peers might be a bit premature of an optimisation so I moved it to a manual button for now. A user might have the intention of adding a peer and opening a channel with that peer at a later stage and with this method the peer would be removed on each start up.
Linked Issues/Tasks
https://github.com/orgs/synonymdev/projects/12/views/1?pane=issue&itemId=69388158
synonymdev/react-native-ldk#259
Type of change
Tests
Screenshot / Video
Insert relevant screenshot / recording
QA Notes
After adding an external peer, restore from remote backup and peer should still be there. Or if there was a channel from another LSP it should still be usable.