Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transfer): update transfer flow #2165

Merged
merged 1 commit into from
Aug 27, 2024
Merged

feat(transfer): update transfer flow #2165

merged 1 commit into from
Aug 27, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Aug 26, 2024

Description

Update transfer UI from design updates v50

Linked Issues/Tasks

Closes #2081 #2159

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-26.at.17.47.37.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-26.at.17.55.28.mp4

@pwltr pwltr requested a review from limpbrains as a code owner August 26, 2024 15:56
src/screens/Transfer/SavingsProgress.tsx Show resolved Hide resolved
src/screens/Transfer/SavingsProgress.tsx Show resolved Hide resolved
src/screens/Transfer/SpendingAdvanced.tsx Show resolved Hide resolved
src/screens/Transfer/SpendingAdvanced.tsx Outdated Show resolved Hide resolved
src/screens/Transfer/SpendingAdvanced.tsx Outdated Show resolved Hide resolved
@pwltr pwltr force-pushed the feat/transfer-v50 branch 2 times, most recently from 10f7f41 to 7b09e41 Compare August 26, 2024 21:59
try {
// Ensure we're fully up-to-date.
const refreshRes = await refreshLdk({ selectedWallet, selectedNetwork });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pwltr pwltr merged commit d94cc3c into master Aug 27, 2024
7 checks passed
@pwltr pwltr deleted the feat/transfer-v50 branch August 27, 2024 11:17
@pwltr pwltr linked an issue Aug 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Max channel duration 52 weeks (instead of 12) Transfer (v50)
2 participants