Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decode revert error #390

Merged
merged 4 commits into from
Dec 7, 2023
Merged

feat: decode revert error #390

merged 4 commits into from
Dec 7, 2023

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Dec 5, 2023 •
edited by Flouse
Loading

Closes: #274

Description

PR author checklist:

  • Added tests: integration (for Forcerelay) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@blckngm blckngm mentioned this pull request Dec 5, 2023
Closed
7 tasks
@blckngm blckngm added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit fbb4dce Dec 7, 2023
31 checks passed
@blckngm blckngm deleted the decode-revert-error branch December 8, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashuralyk ashuralyk ashuralyk approved these changes

@jjyr jjyr Awaiting requested review from jjyr

@wenyuanhust wenyuanhust Awaiting requested review from wenyuanhust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The error from solidity contract is hex encoded, we should parse it to human-readable string format
3 participants
@blckngm @ashuralyk @wenyuanhust