-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refator: refator some code of Ckb4Ibc endpoint, solved some fatal bugs #364
Conversation
1ad1724
to
6a59831
Compare
6a59831
to
18bb928
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the contract version changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I'll fix it |
I doubt this workflow quotes toml in main branch, I check it later currently, it's ok https://github.com/synapseweb3/forcerelay/actions/runs/6720166618/job/18263158005?pr=364 |
background
there are so many bugs in Axon and CKB endpoints which can stop relaying packet events or just miss some of them, to unwrap, here are some reasons make this case happen:
ckb-indexer
, so the packet event beyonds 5th won't processquery_*
methods both in Axon and CKB endpoints isn't working well (CKB is worse), and Hermes uses them to indicate wether the counterparty has handled the unhandled packet eventsWriteAck
packet cell in CKB endpoint should be consumed in the next time of creating newRecvPacket
cell, if not do this,WriteAck
packet cell is accumulating and consuming relayer's CKB capacitychange logs
ckb-indexer
in a loop processquery_*
methods are refactored in CKB endpointWriteAck
packet cellsrelated PRs