Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace axon-tools #359

Closed
wants to merge 3 commits into from
Closed

feat: replace axon-tools #359

wants to merge 3 commits into from

Conversation

wenyuanhust
Copy link
Contributor

@wenyuanhust wenyuanhust commented Oct 30, 2023 •
edited
Loading

Closes: #XXX

Description

  • change dependency from axon-tools to axon
  • update related dependency from 0.108 to 0.111
  • update eth-light-client-in-ckb, mmr deleted trait MMRStore
  • !!! the crates imported are private repository of mine

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Forcerelay) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Flouse
Flouse requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@Flouse Flouse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

Conflicting files

Cargo.lock
crates/relayer-types/Cargo.toml
crates/relayer/Cargo.toml
crates/relayer/src/chain/axon/utils.rs

@blckngm blckngm linked an issue Oct 30, 2023 that may be closed by this pull request
Upgrade ckb deps #352
Closed
@wenyuanhust wenyuanhust closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ckb deps
2 participants
@wenyuanhust @Flouse