feat(ibc-test): use ICS20TransferERC20, remove MockTransfer #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
force-pushed
the
remove-axon-mock-transfer-contract
branch
from
4f0fd60
to
b465f2f
Compare
ashuralyk
reviewed
Oct 23, 2023
| let key_name = key_name.unwrap_or(&self.config.key_name); | ||
| let denom: &str = | ||
| denom.ok_or_else(|| Error::other_error("do not support default denom".into()))?; | ||
| let erc20_address = { |
There was a problem hiding this comment.
use denom as erc20 address is compatible with the previous use in CI?
There was a problem hiding this comment.
Yes, by my understanding, the CI is using erc20 address as the env DENOM.
blckngm
reviewed
Oct 23, 2023
| // let denom = denom.unwrap_or(DEFAULT_DENOM); | ||
| // let contract = self.ics20_contract()?; | ||
| // let wallet = self.get_wallet(key_name); | ||
| fn query_balance(&self, key_name: Option<&str>, denom: Option<&str>) -> Result<Balance, Error> { |
There was a problem hiding this comment.
This only works for source denoms, for sink denoms we would need to lookup the denomTokenContract mapping. (Not saying that it should be implemented now. Just a reminder.)
blckngm
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ICS20TransferERC20 to replace the MockTransfer in IBC tests.
We also deployed a SimpleToken(both name and symbol are 'AT') ERC-20 contract used as the default token in IBC tests.
See also synapseweb3/ibc-solidity-contract#29