Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix create connection for axon chain #242

Merged
merged 3 commits into from
Jun 29, 2023
Merged

chore: fix create connection for axon chain #242

merged 3 commits into from
Jun 29, 2023

Conversation

fjchen7
Copy link
Contributor

@fjchen7 fjchen7 commented Jun 28, 2023

Closes: #XXX

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Forcerelay) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@fjchen7 fjchen7 requested a review from ashuralyk June 28, 2023 02:42
@fjchen7 fjchen7 merged commit eb20984 into main Jun 29, 2023
23 of 30 checks passed
@ashuralyk ashuralyk deleted the chore/fix-create-connection-for-axon branch July 19, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashuralyk ashuralyk ashuralyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjchen7 @ashuralyk