pytest-lsp: Bump pytest-asyncio to 0.24

lib/pytest-lsp/changes/182.misc.md

@@ -0,0 +1 @@
+Bump minimum `pytest-asyncio` verision to `v0.24`

lib/pytest-lsp/pyproject.toml

@@ -27,7 +27,7 @@ dependencies = [
     "packaging",
     "pygls>=2.0.0a1",
     "pytest",
-    "pytest-asyncio>=0.23",
+    "pytest-asyncio>=0.24",
 ]
 
 [project.urls]
@@ -48,6 +48,7 @@ sort = "Cover"
 
 [tool.pytest.ini_options]
 asyncio_mode = "auto"
+asyncio_default_fixture_loop_scope = "function"
 
 [tool.towncrier]
 filename = "CHANGES.md"

lib/pytest-lsp/pytest_lsp/plugin.py

@@ -196,6 +196,11 @@ def fixture(
     """
 
     def wrapper(fn):
+        # pytest-asyncio says `loop_scope` should be present and match `scope`
+        # https://pytest-asyncio.readthedocs.io/en/latest/how-to-guides/migrate_from_0_23.html
+        if "scope" in kwargs:
+            kwargs["loop_scope"] = kwargs["scope"]
+
         @pytest_asyncio.fixture(**kwargs)
         async def the_fixture(request):
             devtools = request.config.getoption("devtools")

lib/pytest-lsp/tests/examples/fixture-scope/t_server.py

@@ -21,7 +21,7 @@ async def client(lsp_client: LanguageClient):
     await lsp_client.shutdown_session()
 
 
-@pytest.mark.asyncio(scope="module")
+@pytest.mark.asyncio(loop_scope="module")
 async def test_completion_hello(client: LanguageClient):
     """Ensure that the server implements completions correctly."""
 
@@ -42,7 +42,7 @@ async def test_completion_hello(client: LanguageClient):
     assert "hello" in labels
 
 
-@pytest.mark.asyncio(scope="module")
+@pytest.mark.asyncio(loop_scope="module")
 async def test_completion_world(client: LanguageClient):
     """Ensure that the server implements completions correctly."""
 

lib/pytest-lsp/tests/test_client.py

@@ -61,6 +61,7 @@ def test_client_capabilities(
         """
         [pytest]
         asyncio_mode = auto
+        asyncio_default_fixture_loop_scope = function
         """
     )
 
@@ -116,7 +117,7 @@ async def test_capabilities(client):
     )
 
     results = pytester.runpytest("-vv")
-    results.assert_outcomes(passed=1)
+    results.assert_outcomes(passed=1, warnings=0)
 
 
 @pytest.mark.parametrize(

lib/pytest-lsp/tests/test_examples.py

@@ -10,6 +10,7 @@ def setup_test(pytester: pytest.Pytester, example_name: str):
         """\
 [pytest]
 asyncio_mode = auto
+asyncio_default_fixture_loop_scope = function
 """
     )
 
@@ -24,21 +25,35 @@ def setup_test(pytester: pytest.Pytester, example_name: str):
 @pytest.mark.parametrize(
     "name, expected",
     [
-        pytest.param("diagnostics", dict(passed=1), id="diagnostics"),
-        pytest.param("getting-started", dict(passed=1), id="getting-started"),
-        pytest.param("fixture-passthrough", dict(passed=1), id="fixture-passthrough"),
-        pytest.param("fixture-scope", dict(passed=2), id="fixture-scope"),
+        pytest.param("diagnostics", dict(passed=1, warnings=0), id="diagnostics"),
         pytest.param(
-            "parameterised-clients", dict(passed=2), id="parameterised-clients"
+            "getting-started", dict(passed=1, warnings=0), id="getting-started"
+        ),
+        pytest.param(
+            "fixture-passthrough", dict(passed=1, warnings=0), id="fixture-passthrough"
+        ),
+        pytest.param("fixture-scope", dict(passed=2, warnings=0), id="fixture-scope"),
+        pytest.param(
+            "parameterised-clients",
+            dict(passed=2, warnings=0),
+            id="parameterised-clients",
+        ),
+        pytest.param(
+            "window-log-message", dict(passed=1, warnings=0), id="window-log-message"
         ),
-        pytest.param("window-log-message", dict(passed=1), id="window-log-message"),
         pytest.param(
             "window-create-progress",
-            dict(passed=3),
+            dict(passed=3, warnings=0),
             id="window-create-progress",
         ),
-        pytest.param("window-show-document", dict(passed=1), id="window-show-document"),
-        pytest.param("window-show-message", dict(passed=1), id="window-show-message"),
+        pytest.param(
+            "window-show-document",
+            dict(passed=1, warnings=0),
+            id="window-show-document",
+        ),
+        pytest.param(
+            "window-show-message", dict(passed=1, warnings=0), id="window-show-message"
+        ),
         pytest.param(
             "workspace-configuration",
             dict(passed=1, warnings=1),

lib/pytest-lsp/tests/test_plugin.py

@@ -79,6 +79,7 @@ def setup_test(pytester: pytest.Pytester, server_name: str, test_code: str):
         """\
 [pytest]
 asyncio_mode = auto
+asyncio_default_fixture_loop_scope = function
 """
     )