Merge pull request #75 from swup/fix/update-link-to-fragment-for-same…

…-url
swup · May 21, 2024 · 5d0b003 · 5d0b003
2 parents 6f0f43d + 1c5101e
commit 5d0b003
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/inc/defs.ts b/src/inc/defs.ts
@@ -7,7 +7,7 @@ export type Route = {
 };
 
 /** The interface for an augmented Fragment Element */
-export interface FragmentElement extends Element {
+export interface FragmentElement extends HTMLElement {
 	__swupFragment?: {
 		url?: string;
 		selector?: string;

diff --git a/src/inc/functions.ts b/src/inc/functions.ts
@@ -73,7 +73,6 @@ function handleLinksToFragments({ logger, swup }: FragmentPlugin): void {
 		if (isEqualUrl(fragmentUrl, swup.getCurrentUrl())) {
 			// prettier-ignore
 			if (__DEV__) logger?.warn(`The fragment URL of ${selector} is identical to the current URL. This could mean that [data-swup-fragment-url] needs to be provided by the server.`);
-			return;
 		}
 
 		el.href = fragmentUrl;
@@ -372,7 +371,7 @@ export function queryFragmentElement(
 ): FragmentElement | undefined {
 	for (const containerSelector of swup.options.containers) {
 		const container = document.querySelector(containerSelector);
-		if (container?.matches(fragmentSelector)) return container;
+		if (container?.matches(fragmentSelector)) return container as FragmentElement;
 
 		const fragment = container?.querySelector<FragmentElement>(fragmentSelector);
 		if (fragment) return fragment;