Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliceable MetaData Class #455

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

Sliceable MetaData Class #455

wants to merge 76 commits into from
+1,230 −19

Commits on Aug 13, 2021

  1. First draft of a sliceable meta obect.

    @DanRyanIrish
    DanRyanIrish committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    ff9b13e View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Refactor Meta. Tests now passing. 

    Refactor involved moving comments and axes out of the core values and
putting them into their own dictionaries.  This removed cascading
consequences for self.values(), self.__setitem__, etc.
    @DanRyanIrish
    DanRyanIrish committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    6d0d254 View commit details
    Browse the repository at this point in the history

  2. Add overwrite option to Meta.add. 

    Also put in overwrite error check to Meta.__setitem__ if axis is not
None.  This way the value shape and axes cannot easily be corrupted
accidentally.
    @DanRyanIrish
    DanRyanIrish committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    9166378 View commit details
    Browse the repository at this point in the history

  3. Fixes codestyle.

    @DanRyanIrish
    DanRyanIrish committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    a2248c7 View commit details
    Browse the repository at this point in the history

  4. Adds sunpy#455 changelog.

    @DanRyanIrish
    DanRyanIrish committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    02cdcbb View commit details
    Browse the repository at this point in the history

  5. Codestyle fixes.

    @DanRyanIrish
    DanRyanIrish committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    eb57c05 View commit details
    Browse the repository at this point in the history

  6. Slice meta if possible when slicing NDCube.

    @DanRyanIrish
    DanRyanIrish committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    96b8ab9 View commit details
    Browse the repository at this point in the history

  7. Add docstrings to Meta object.

    @DanRyanIrish
    DanRyanIrish committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    303320a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Create remove method for Meta.

    @DanRyanIrish
    DanRyanIrish committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    3cc208d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    2b5d507 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Make Meta more memory efficient. 

    Only store entries in the comments and axes dicts that aren't None.
This saves a lot of space and requires the get method be used when
looking for comment and axes values to avoid errors is that key doesn't
have a comment or axis.
    @DanRyanIrish
    DanRyanIrish committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    041cd1b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    3bdf4a6 View commit details
    Browse the repository at this point in the history

  2. Add Meta to top-level init imports.

    @DanRyanIrish
    DanRyanIrish committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    cd13518 View commit details
    Browse the repository at this point in the history

  3. Enable Meta object's shape to be set without axes being set.

    @DanRyanIrish
    DanRyanIrish committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    ad88f5f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    873d5b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    1d54ba3 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    f8c59ed View commit details
    Browse the repository at this point in the history

  2. Avoid possible indexing error when dropping axes during slicing of Me… 

    …ta object.
    @DanRyanIrish
    DanRyanIrish committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    4611e1e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    048e0ed View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    aa817fd View commit details
    Browse the repository at this point in the history

  2. Make NDCube slice meta if it has a magic attribute. 

    This gives more control over slicing the meta correctly.
    @DanRyanIrish
    DanRyanIrish committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    cf923f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    b0e21be View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into meta

    @DanRyanIrish
    DanRyanIrish committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7df22e7 View commit details
    Browse the repository at this point in the history

  2. Fixes codestyle.

    @DanRyanIrish
    DanRyanIrish committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bbe6c12 View commit details
    Browse the repository at this point in the history

  3. Reverting unintented changes to __init__.py

    @DanRyanIrish
    DanRyanIrish committed May 7, 2024
    Configuration menu
    Copy the full SHA
    86dc366 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    @DanRyanIrish @nabobalis
    DanRyanIrish and nabobalis committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7160dc3 View commit details
    Browse the repository at this point in the history

  2. Adds nitpicky exceptions for Meta docstring.

    @DanRyanIrish
    DanRyanIrish committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b3d439c View commit details
    Browse the repository at this point in the history

  3. Try fixing hyperlink to "iterable" 

    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    @DanRyanIrish @nabobalis
    DanRyanIrish and nabobalis committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1f04d62 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @nabobalis
    nabobalis committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c27d904 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @nabobalis
    nabobalis committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8291189 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @nabobalis
    nabobalis committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5604de0 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @nabobalis
    nabobalis committed May 8, 2024
    Configuration menu
    Copy the full SHA
    cdece82 View commit details
    Browse the repository at this point in the history

  8. Update ndcube/tests/test_meta.py

    @nabobalis
    nabobalis committed May 8, 2024
    Configuration menu
    Copy the full SHA
    51617e6 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Change denotation of metadata not associated with axes in Meta class … 

    …from None to empty tuple.
    @DanRyanIrish
    DanRyanIrish committed May 9, 2024
    Configuration menu
    Copy the full SHA
    72bccb0 View commit details
    Browse the repository at this point in the history

  2. Make NDCube.rebin remove axis-awareness from metadata associated with… 

    … rebinned axes.
    @DanRyanIrish
    DanRyanIrish committed May 9, 2024
    Configuration menu
    Copy the full SHA
    120596d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'meta' of https://github.com/DanRyanIrish/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f3fc5a2 View commit details
    Browse the repository at this point in the history

  4. Fix codestyle

    @DanRyanIrish
    DanRyanIrish committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ad39c81 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ad0e532 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Add test of meta handling by NDCube.rebin.

    @DanRyanIrish
    DanRyanIrish committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d01f6f6 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Add rebin capability to Meta.

    @DanRyanIrish
    DanRyanIrish committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d5ae2ef View commit details
    Browse the repository at this point in the history

  2. Fix codestyle.

    @DanRyanIrish
    DanRyanIrish committed May 13, 2024
    Configuration menu
    Copy the full SHA
    181d86d View commit details
    Browse the repository at this point in the history

  3. Adds tests for Meta.rebin.

    @DanRyanIrish
    DanRyanIrish committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f17ba0b View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed May 19, 2024
    Configuration menu
    Copy the full SHA
    da8df25 View commit details
    Browse the repository at this point in the history

  2. Support scalar axis-aware metadata.

    @DanRyanIrish
    DanRyanIrish committed May 19, 2024
    Configuration menu
    Copy the full SHA
    fb45151 View commit details
    Browse the repository at this point in the history

  3. Add support for axis-aware metadata that give a scalar per axis.

    @DanRyanIrish
    DanRyanIrish committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9726b65 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Clarify behavior of axis-aligned and grid-aligned metadata and fix co… 

    …de to reflect newly defined behavior.
    @DanRyanIrish
    DanRyanIrish committed May 20, 2024
    Configuration menu
    Copy the full SHA
    a626602 View commit details
    Browse the repository at this point in the history

  2. Make API of Meta.rebin more flexible.

    @DanRyanIrish
    DanRyanIrish committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e848e9f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    500843f View commit details
    Browse the repository at this point in the history

  2. change name for metadata used by Meta class from header to meta

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    754385e View commit details
    Browse the repository at this point in the history

  3. Update ndcube/meta.py 

    Co-authored-by: Stuart Mumford <stuart@cadair.com>
    @DanRyanIrish @Cadair
    DanRyanIrish and Cadair committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e8f9535 View commit details
    Browse the repository at this point in the history

  4. Rename Meta to NDMeta. 

    Also fix bugs introduced by changin header to meta as NDMeta's
internal name for the metadata.
    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    fef0de6 View commit details
    Browse the repository at this point in the history

  5. Move ndcube_can_slice and ndcube_can_rebin to class attributes of NDM… 

    …eta.
    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    28eafbb View commit details
    Browse the repository at this point in the history

  6. Create NDMetaABC.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    40b8b26 View commit details
    Browse the repository at this point in the history

  7. Move slicing by data item in NDMeta to new slice method.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3ba2d9c View commit details
    Browse the repository at this point in the history

  8. Change NDMeta.shape to data_shape.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f723445 View commit details
    Browse the repository at this point in the history

  9. Make NDMeta infer data_shape if not provided. 

    Currently creates a bug in NDMeta.rebin.
    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6d84e56 View commit details
    Browse the repository at this point in the history

  10. Refactor NDMeta.rebin to take bin_shape as input.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    bf078bd View commit details
    Browse the repository at this point in the history

  11. Remove data_shape kwarg from NDMeta init.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    81b84e5 View commit details
    Browse the repository at this point in the history

  12. Fix codestyle.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b526e3e View commit details
    Browse the repository at this point in the history

  13. Add setter for NDMeta.data_shape.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    cdc3f8f View commit details
    Browse the repository at this point in the history

  14. Replace NDMeta.remove with __delitem__.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2373209 View commit details
    Browse the repository at this point in the history

  15. Make NDCube.meta have same shape as NDCube if meta is axis-aware.

    @DanRyanIrish
    DanRyanIrish committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6d38c67 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Fix codestyle.

    @DanRyanIrish
    DanRyanIrish committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    fb788f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Stuart Mumford <stuart@cadair.com>
    @DanRyanIrish @Cadair
    DanRyanIrish and Cadair committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f315ca6 View commit details
    Browse the repository at this point in the history

  2. Change NDMeta.comments to key_comments. 

    And other minor changes suggested by code review.
    @DanRyanIrish
    DanRyanIrish committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    d81db9e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'meta' of https://github.com/DanRyanIrish/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b59cbff View commit details
    Browse the repository at this point in the history

  4. Make NDMeta.original_header read-only.

    @DanRyanIrish
    DanRyanIrish committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5776dca View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. First incomplete version of docs on NDMeta.

    @DanRyanIrish
    DanRyanIrish committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5076384 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    bebcf1f View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. First complete draft of metadata narrative docs.

    @DanRyanIrish
    DanRyanIrish committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    8127514 View commit details
    Browse the repository at this point in the history

  2. Enable NDMeta to accept data shape on instantiation.

    @DanRyanIrish
    DanRyanIrish committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    c4a83aa View commit details
    Browse the repository at this point in the history

  3. Enable NDCubeSequence and NDCollection to support sliceable metadata.

    @DanRyanIrish
    DanRyanIrish committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    d79a5e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Add tests for meta slicing via NDCubeSequence and NDCollection.

    @DanRyanIrish
    DanRyanIrish committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7f9f042 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Merge branch 'main' of https://github.com/sunpy/ndcube into meta

    @DanRyanIrish
    DanRyanIrish committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    e35c34c View commit details
    Browse the repository at this point in the history

  2. Fixes to make NDMeta slicing work, especially as part of an NDCollect… 

    …ion.
    @DanRyanIrish
    DanRyanIrish committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    a58c705 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Some docs bugfixes relating to NDMeta.

    @DanRyanIrish
    DanRyanIrish committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    944b0df View commit details
    Browse the repository at this point in the history