Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use backend task to manage apdu exchange via hidapi #126

Merged
merged 4 commits into from
Nov 25, 2023
Merged

refactor: use backend task to manage apdu exchange via hidapi #126

merged 4 commits into from
Nov 25, 2023

Conversation

prestwich
Copy link
Member

Modifies coins-ledger in the following ways:

  • remove unnecessary NativeTransport wrapper
  • improve asyncification for native transports:
    • add a LedgerTask running on a separate thread,
    • add a LedgerHandle for communicating with it
    • this should prevent any accidental blocking of the tokio executor
  • add experimental LedgerProtocol trait
  • resolve non-Send futures issue (closes can Ledger be Send ? #124 and supersedes Wrap device in Arc<Mutex<_>> #125)
  • bumps version to 0.9.0
  • misc cleanup of comments and error messages

this has been tested against a ledger on SE 1.5.5 & MCU 1.7 with Ethereum app 1.2.11

@prestwich prestwich added the enhancement New feature or request label Nov 25, 2023
@prestwich prestwich self-assigned this Nov 25, 2023
@prestwich prestwich mentioned this pull request Nov 25, 2023
Closed
DaniPopes
DaniPopes approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestwich prestwich merged commit 2deaea0 into main Nov 25, 2023
6 checks passed
@naps62 naps62 mentioned this pull request Nov 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can Ledger be Send ?
2 participants
@prestwich @DaniPopes