Snapshot support #1100
Draft
Snapshot support #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mulhern <amulhern@redhat.com>
|
Expect test failures |
|
Expect all tests to pass |
mulkieran
force-pushed
the
snapshot-support
branch
from
187876b
to
6cb0a24
Compare
|
Really this time... |
mulkieran
force-pushed
the
snapshot-support
branch
from
6cb0a24
to
0a1f79b
Compare
|
/packit build |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Signed-off-by: mulhern <amulhern@redhat.com>
Just return the engine error if origin not set. When trying to cancel a revert, and the revert has not been scheduled because the filesystem has no origin, better to reject the cancel action because of the missing origin, rather than because the merge status will not be changed. Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com> (cherry picked from commit 39c87a8)
The revised text for the "Snapshot origin" field now looks like this:
Snapshot origin
If this filesystem is a snapshot, its origin. If the filesystem is
a snapshot, whether or not it is scheduled to replace its origin
next time the pool is started.
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
snapshot-support
branch
from
0a1f79b
to
62e6922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.