Issue stratis cli 1085 #1087
Draft
Issue stratis cli 1085 #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
4 times, most recently
from
fd63c05
to
fe70404
Compare
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
from
2118423
to
3893caa
Compare
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
from
3893caa
to
580f136
Compare
|
/packit build |
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
from
580f136
to
131eb93
Compare
|
Failing on coverage... |
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
from
131eb93
to
b37f4d0
Compare
|
/packit build |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
from
9518aa1
to
ec378e4
Compare
|
Will need to update man pages for change to filesystem listing, but that is about all. |
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
from
ec378e4
to
201248b
Compare
Just return the engine error if origin not set. When trying to cancel a revert, and the revert has not been scheduled because the filesystem has no origin, better to reject the cancel action because of the missing origin, rather than because the merge status will not be changed. Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
The revised text for the "Snapshot origin" field now looks like this:
Snapshot origin
If this filesystem is a snapshot, its origin. If the filesystem is
a snapshot, whether or not it is scheduled to replace its origin
next time the pool is started.
Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
issue_stratis-cli_1085
branch
from
201248b
to
b2006c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1085