feat(local-ic): bash driver #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
AntiTyping
approved these changes
Aug 15, 2024
|
Looks good. One thing that I would add in the future would be some help message if a bash function is called with the wrong number of arguments - but that depends on feedback from users. The scripts are easy to understand and anyone who has knowledge of cosmos should not have an issue with reading them. |
AntiTyping
reviewed
Aug 15, 2024
local-interchain/bash/source.bash
Outdated
| ICT_ADD_FULL_NODE() { | ||
| API=$1 | ||
| CHAIN_ID=$2 | ||
| AMOUNT=$3 |
There was a problem hiding this comment.
I would consider using local
local API=$1, CHAIN_ID=$2, AMOUNT=$3
in this way variables will not leak into outside context which might make debugging harder especially if multiple functions are called in succession with different args
There was a problem hiding this comment.
resolved in: 92e712f
joelsmith-2019
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #795
Summary
Basic external bash driver which can be imported to interact with local-ic. Why? it's easier sometimes and I find myself wanting a helper constantly.