Added missing fstab object to SwapSpace #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
requested changes
Nov 2, 2023
japokorn
force-pushed
the
3.9-devel-fstab_swap_fix
branch
from
5f8e8a1
to
d7186c3
Compare
|
Added the test. Also modified the code so now unnecessary logic is skipped if no fstab is to be written (see updated description). |
Anaconda tests revealed missing FSTabOptions object in SwapSpace class. This issue is related to the recent merge of fstab rework PR storaged-project#1119 which added this object to FS class. SwapSpace does not inherit from FS and was overlooked. This change adds the missing object. It also adds logic that skips all fstab related operations if fstab file is not to be written (i.e. fstab.dest_file is None). The reason for this is to eliminate the risk of potential issues caused by unused component. The test for above has been added as well.
japokorn
force-pushed
the
3.9-devel-fstab_swap_fix
branch
from
d7186c3
to
179381c
Compare
vojtechtrefny
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anaconda tests revealed missing
FSTabOptionsobject inSwapSpaceclass.This issue is related to the recent merge of fstab rework #1119 which
added this object to
FSclass.SwapSpacedoes not inherit fromFSandwas overlooked. This change adds the missing object.
It also adds logic that skips all fstab related operations if fstab file
is not to be written (i.e.
fstab.dest_file is None). The reason for this is toeliminate the risk of potential issues caused by unused component.
The test for above has been added as well.