only pass character vectors to numeric_version

stevenpawley · Jun 21, 2023 · 5cb615f · 5cb615f
1 parent 4c3bb33
commit 5cb615f
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 8 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -1,3 +1,3 @@
-Version: 0.4.0
-Date: 2023-05-26 03:18:37 UTC
-SHA: 7b78753a95ce66c8f553ad075ecf068eba0b0eba
+Version: 0.4.1
+Date: 2023-06-21 02:54:46 UTC
+SHA: 4c3bb336ad6400ba369b95bf9fe19db0594b193d
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: Rsagacmd
 Type: Package
 Title: Linking R with the Open-Source 'SAGA-GIS' Software
-Version: 0.4.0
+Version: 0.4.1
 Date: 2023-05-25
 Authors@R: c(
     person("Steven", "Pawley",

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,8 @@
-# Rsagacmd 0.3
+# Rsagacmd 0.41
+
+Minor fix to only pass character vectors to 'numeric_version'
+
+# Rsagacmd 0.4
 
 Changes:
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -0,0 +1,6 @@
+## R CMD check results
+
+0 errors | 0 warnings | 0 note
+
+* Minor update to address CRAN issue related to passing a numeric instead of a
+character vector to numeric_version()
diff --git a/tests/testthat/test-data-formats.R b/tests/testthat/test-data-formats.R
@@ -34,7 +34,7 @@ test_that("test raster formats (SAGA)", {
 test_that("test raster formats (SAGA Compressed)", {
   testthat::skip_on_cran()
   testthat::skip_if(is.null(search_saga()))
-  testthat::skip_if(saga_version(search_saga()) < numeric_version(5.0))
+  testthat::skip_if(saga_version(search_saga()) < numeric_version("5.0"))
 
   saga <- saga_gis(raster_format = "SAGA Compressed")
   dem <- saga$grid_calculus$random_terrain()
@@ -58,7 +58,7 @@ test_that("test raster formats (SAGA Compressed)", {
 test_that("test vector formats (GeoPackage)", {
   testthat::skip_on_cran()
   testthat::skip_if(is.null(search_saga()))
-  testthat::skip_if(saga_version(search_saga()) < numeric_version(5.0))
+  testthat::skip_if(saga_version(search_saga()) < numeric_version("5.0"))
 
   saga <- saga_gis(vector_format = "GeoPackage")
 

diff --git a/tests/testthat/test-utils.R b/tests/testthat/test-utils.R
@@ -1,7 +1,7 @@
 testthat::test_that("tile geoprocessor function", {
   testthat::skip_on_cran()
   testthat::skip_if(is.null(search_saga()))
-  testthat::skip_if(saga_version(search_saga()) < numeric_version(7.0))
+  testthat::skip_if(saga_version(search_saga()) < numeric_version("7.0"))
 
   saga <- saga_gis()