Skip to content

Commit

Permalink
chore: update review example (#81)
Browse files Browse the repository at this point in the history
This includes more content, and markdown formatting examples
  • Loading branch information
stanistan committed Jul 6, 2023
1 parent 46548db commit 2502817
Showing 1 changed file with 17 additions and 16 deletions.
33 changes: 17 additions & 16 deletions frontend/pages/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@
slideshow-like presentation, in the order that the comments are desired to appear, and only the
diffs that are annotated with comments, leaving all other changes out of mind.
</p>

<p class="mb-2">
These are all valid URLs to query for:
</p>

<ul class="list-disc ml-4 mb-4">
<li
v-for="u in validURLs" :key="u.url"
Expand Down Expand Up @@ -89,22 +91,21 @@ async function goTo(url) {
await search();
}
// the building blocks of what we're building up here...
// easy to change to another example later on.
const implicit = 'stanistan/present-me/pull/76';
const review = '1494150314';
// and the building up.
const noDomain = `${implicit}#pullrequestreview-${review}`;
const noProtocol = `github.com/${noDomain}`;
const fqr = `https://${noProtocol}`;
const validURLs = [
{
why: 'Fully qualified Pull Request Review URL (the permalink from Github)',
url: 'https://github.com/stanistan/present-me/pull/56#pullrequestreview-1419621494',
},
{
why: 'Dropping the Protocol (https is implicit)',
url: 'github.com/stanistan/present-me/pull/56#pullrequestreview-1419621494'
},
{
why: 'Dropping the domain (https://github.com is implicit)',
url: 'stanistan/present-me/pull/56#pullrequestreview-1419621494'
},
{
why: 'Dropping the URL fragment... will attempt to find the first Review by the PR author',
url: 'stanistan/present-me/pull/56'
}
{ why: 'Fully qualified Pull Request Review URL (the permalink from Github)', url: fqr },
{ why: 'Dropping the Protocol (https is implicit)', url: noProtocol },
{ why: 'Dropping the domain (https://github.com is implicit)', url: noDomain },
{ why: 'Dropping the URL fragment... will attempt to find the first Review by the PR author', url: implicit }
];
</script>

0 comments on commit 2502817

Please sign in to comment.