Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new notebook to show the statistics of the enclosed object with… #274

Merged
merged 12 commits into from
Aug 21, 2024

Conversation

ZoeJacky
Copy link
Collaborator

@ZoeJacky ZoeJacky commented Jun 4, 2024

… psydat file

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good start - could you use vstt.Experiment to open the psydat file instead of fromFile ? (as done here https://github.com/ssciwr/vstt/blob/main/docs/notebooks/example.ipynb - that way they start with the statistics dataframe with labelled columns which should hopefully be an easier place to start than just the raw data)

Also could you add this file to https://github.com/ssciwr/vstt/blob/main/docs/index.rst so that it is included in the documentation?

The velocity plots look a little strange, I think the near-discontinuity in the velocity after each target is due to concatenating just the movement to target values, so there is an instantaneous jump where the movement to center values are missing. I think either the movement to center values should be included, or the transition between targets where the discontinuity is should not be included.

@ZoeJacky
Copy link
Collaborator Author

You're right, Liam, I didn't include the "to_center" path.
I will also use "vstt.Experiment" to open the psydat file and add this notebook to documentation.

…city to index.rst, plot the to_center velocity
Copy link

sonarcloud bot commented Aug 21, 2024

@ZoeJacky ZoeJacky merged commit 79c0812 into main Aug 21, 2024
9 of 16 checks passed
@ZoeJacky ZoeJacky deleted the path_velocity_plotting_and_smoothing branch August 21, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants