Fix fixed target display intervals additional delay bug #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- repeat of condition with `fixed target display intervals` now continues the same fixed intervals - previously the time from the last target of the previous trial was not taken into account - this meant the first target of each repeat had a longer delay than desired - store the time used by most recent target for current / previous trial in `TaskManager` to allow this - extend `test_task_fixed_intervals_no_user_input` to include this case in tests - bump version to 1.3.2 - update changelog - add `gnome-screenshot` to linux CI deps - resolves #256
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 90.01% 90.03% +0.02%
==========================================
Files 19 19
Lines 1602 1606 +4
==========================================
+ Hits 1442 1446 +4
Misses 160 160 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed target display intervalsnow continues the same fixed intervalsTaskManagerto allow thistest_task_fixed_intervals_no_user_inputto include this case in tests