add spatial error and unit test cases #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 90.01% 90.09% +0.08%
==========================================
Files 19 19
Lines 1602 1615 +13
==========================================
+ Hits 1442 1455 +13
Misses 160 160 ☔ View full report in Codecov by Sentry. |
lkeegan
reviewed
Nov 28, 2023
docs/reference/statistics.rst
Outdated
| :alt: Spatial Error is the distance from movement end point and the center of the target minus target' radius | ||
|
|
||
| The cursor location at a timestamp is given by a pair of :math:`(x, y)` coordinates, | ||
| where :math:`(0, 0)` corresponds to the center of the screen, and 1 in these units is equal to the screen height per second squared. |
There was a problem hiding this comment.
Suggested change
| where :math:`(0, 0)` corresponds to the center of the screen, and 1 in these units is equal to the screen height per second squared. | |
| where :math:`(0, 0)` corresponds to the center of the screen, and 1 in these units is equal to the screen height. |
src/vstt/stats.py
Outdated
| end_point = mouse_position[-1] | ||
| else: | ||
| return 0 | ||
| if xydist(end_point, target) >= target_radius: |
There was a problem hiding this comment.
To simplfy the logic & avoid duplication maybe something like this would be cleaner?:
if mouse_position.size < 1:
return 0
spatial_error = xydist(mouse_position[-1], target) - target_radius
return max(spatial_error, 0)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spatial error: the gap between the last point of the cursor movement path to the center of the target minus target radius.
PS: when the gap <= target radius, spatial error = 0