Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial docker deployment setup #85

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Initial docker deployment setup #85

merged 1 commit into from
Sep 24, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Sep 24, 2024

  • add docker-compose
  • add nginx docker image and nginx conf for frontend
  • remove .env file from backend folder
    • instead make settings default values the ones used for local development
  • replace USER_DATABASE_PATH and MILESTONE_DATABASE_PATH with single DATABASE_PATH folder
  • add mondey_backend/db folder to use as a default location for databases when running backend locally without docker
  • add /api root_path to API, forward all /api locations in nginx to the backend
  • note that nginx config is only http for now

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.42%. Comparing base (3503acb) to head (11107c5).

Files with missing lines Patch % Lines
frontend/src/routes/admin/+page.svelte 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   19.49%   19.42%   -0.07%     
==========================================
  Files          73       73              
  Lines        2904     2903       -1     
  Branches      106      106              
==========================================
- Hits          566      564       -2     
- Misses       2285     2286       +1     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- add docker-compose
- add nginx docker image and nginx conf for frontend
- remove .env file from backend folder
  - instead make settings default values the ones used for local development
- replace USER_DATABASE_PATH and MILESTONE_DATABASE_PATH with single DATABASE_PATH folder
- add mondey_backend/db folder to use as a default location for databases when running backend locally without docker
- add `/api` root_path to API, forward all /api locations in nginx to the backend
- add a docker CI job to build production containers and push to ghcr.io
- note that nginx config is only http for now
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lkeegan lkeegan merged commit 8366926 into main Sep 24, 2024
7 checks passed
@lkeegan lkeegan deleted the docker branch September 24, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants