Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ticking behavior with time.time_ns() #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffdn
Copy link

@jeffdn jeffdn commented Oct 20, 2022

Previously, when freeze_time(..., tick=True) was used in conjunction with functions that called out to time.time_ns(), identical values were being returned. This was caused by the existing version of fake_time_ns rounding off the last nine digits of the returned integer value -- ensuring that each tick would be erased.

This commit only casts to int after the value has been shifted by 1e9, rather than before and after.

Previously, when `freeze_time(..., tick=True)` was used in conjunction
with functions that called out to `time.time_ns()`, identical values
were being returned. This was caused by the existing version of
`fake_time_ns` rounding off the last nine digits of the returned integer
value -- ensuring that each tick would be erased.

This commit only casts to `int` _after_ the value has been shifted by
`1e9`, rather than before _and_ after.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant