Update misnamed eventid #3144
Merged
Update misnamed eventid #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of datasources. this was mostly removing spaces to convert "Sysmon Event ID N" to "Sysmon EventID N". Also fix some ymls that used the field "data_sources" when it should be "data_source"
ljstella
approved these changes
Sep 27, 2024
ljstella
requested changes
Sep 27, 2024
Yes, nice catch! In fact this IS caught by the version-checking, it's just obfuscated by the other error on missing non-public content. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of YMLs had issues around the data_source object(s) in the YMLs.
Either the wrong named were used for Sysmon EventID (a space was accidentally included), the key in the YML was
data_sourcesinstead ofdata_source, or other minor issues.This PR should resolve those issues.