Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valleyrat fixes! #3137

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Valleyrat fixes! #3137

merged 6 commits into from
Sep 25, 2024

Conversation

patel-bhavin
Copy link
Contributor

updates from eric's comments!

@patel-bhavin patel-bhavin requested review from tccontre and pyth0n1c and removed request for ljstella September 24, 2024 20:37
Copy link
Collaborator

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fixes are based on internal feedback and discussion with the developer. They look good to me!

@patel-bhavin
Copy link
Contributor Author

known failures in app inspect!

@patel-bhavin patel-bhavin merged commit 2e0a7c5 into develop Sep 25, 2024
5 of 8 checks passed
@patel-bhavin patel-bhavin deleted the valleyrat branch September 25, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants