Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valleyrat #3129

Merged
merged 9 commits into from
Sep 24, 2024
Merged

valleyrat #3129

merged 9 commits into from
Sep 24, 2024

Conversation

tccontre
Copy link
Contributor

@tccontre tccontre commented Sep 17, 2024

Tagged and modified

  • add_or_set_windows_defender_exclusion.yml
  • cmlua_or_cmstplua_uac_bypass.yml
  • eventvwr_uac_bypass.yml
  • executables_or_script_creation_in_suspicious_path.yml
  • fodhelper_uac_bypass.yml
  • suspicious_process_file_path.yml
  • windows_access_token_manipulation_sedebugprivilege.yml
  • windows_defender_exclusion_registry_entry.yml
  • winevent_windows_task_scheduler_event_action_started.yml

new detections

  • windows_modify_registry_utilize_progids.yml
  • windows_modify_registry_valleyrat_pwn_reg_entry.yml
  • windows_schedule_tasks_for_compmgmtlauncher_or_eventvwr.yml
  • windows_impair_defenses_disable_av_autostart_via_registry.yml
  • windows_modify_registry_valleyrat_c2_config.yml
  • windows_schedule_task_dll_module_loaded.yml

analytic story

  • stories/valleyrat.yml

What does this PR have in it? Screenshots are worth 1000 words 😄

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the datestamp in the lookup CSV filename, and the reference to it in the YAML needs to be updated.

@tccontre tccontre added the WIP DO NOT MERGE Work in Progress label Sep 17, 2024
@tccontre tccontre removed the WIP DO NOT MERGE Work in Progress label Sep 24, 2024
@patel-bhavin patel-bhavin added this to the v4.41.0 milestone Sep 24, 2024
@patel-bhavin patel-bhavin merged commit a5eaa9f into develop Sep 24, 2024
6 checks passed
@patel-bhavin patel-bhavin deleted the valleyrat branch September 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants