Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new detection for CVE-2024-37085 #3067

Closed
wants to merge 14 commits into from

Conversation

TheLawsOfChaos
Copy link
Contributor

Details

What does this PR have in it? Screenshots are worth 1000 words 😄

Create new detection for CVE-2024-37085

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the datestamp in the lookup CSV filename, and the reference to it in the YAML needs to be updated.

Swapping out my custom filter name which was `vmware_esxi_cve-2024-37085_filter` for what the build error says which is `no_name_filter`. No idea why.
…024_37085.yml

Swapped my macro back to the name of my detection, replaced hyphens in filename with underscores.
@MHaggis MHaggis self-requested a review July 30, 2024 20:56
@MHaggis MHaggis self-assigned this Jul 30, 2024
TheLawsOfChaos and others added 5 commits July 30, 2024 16:56
Removed Tweet and additional groups. They are good groups to monitor, but not related to the CVE.
@patel-bhavin
Copy link
Contributor

patel-bhavin commented Jul 30, 2024

We will merge a duplicate of your current PR as we are running into some odd behavior from your fork:develop branch for unit testing : https://github.com/splunk/security_content/pull/3069/files, Closing this PR in favor of the duplicate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants