Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork testing #3033

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fork testing #3033

merged 3 commits into from
Jul 10, 2024

Conversation

patel-bhavin
Copy link
Contributor

@patel-bhavin patel-bhavin commented Jul 10, 2024

@pyth0n1c :updated this code to enables unit testing to successfully execute on both normal PR and PRs created from forks.

Copy link
Collaborator

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have tested this from a separate repo as well.
We will still need to evaluate if testing work from an external repo where its source branch is named "develop" and a few other edge cases, but we should be mostly good!
We should also pursue not hardcoding the repository: security_content and ref: develop, if possible, to make cloning this repo and its workflows work as easily as possible for other users.

@pyth0n1c pyth0n1c merged commit 0dda1b6 into develop Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants