Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nterl0k [T1098] - O365 Azure Workload things #2999

Merged
merged 31 commits into from
Aug 7, 2024

Conversation

nterl0k
Copy link
Contributor

@nterl0k nterl0k commented Apr 13, 2024

Details

This PR includes a number of detections written for the O365 Azure Active Directory workload from the universal audit log (o365 management activity). A few of the detections are 1:1 duplicates of existing ESCU content or expands coverage, only adapted for a slightly easier to access data source. Other detections are focused on monitoring sensitive changes to a number of Azure external access settings.

These detections also extract either the User Principal or Service Principal from the Actor field. Recommend profile your azure environments to populate this data into Assets and Identities.

This PR also includes a number of changes to the "lookups/privileged_azure_ad_roles" lookup and lookup definition, mainly for the purpose of including more known privileged Azure groups relevant in 2024, none of the previous groups were removed.

An additional column has been added to also include the "Template ID" for all groups, which is an immutable GUID used by MS. This GUI should allow for more accurate detections if/when Microsoft changes the string values of well-known objects. (https://learn.microsoft.com/en-us/azure/active-directory/roles/permissions-reference)

Changes to lookup should be backward compatible with existing content.

pending data PR splunk/attack_data#891

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.

nterl0k and others added 20 commits April 20, 2024 14:26
Better User / ServicePrincipal parsing from Actor field
Better user/seviceprincipal parsing from actor field
user/servicepincipal parsing update
user/servicepincipal parsing update
user/servicepincipal parsing update
Update for better ServicePrincipal GUID
Update for better ServicePrincipal GUID
Update for better ServicePrincipal GUID
Update for better ServicePrincipal GUID
Update for better ServicePrincipal GUID
Update for better ServicePrincipal GUID
@ljstella ljstella added this to the v4.37.0 milestone Jul 24, 2024
@ljstella
Copy link
Contributor

Hey @nterl0k ! Long time no talk! Sorry for letting this sit as long as it did. We're working through the backlog now with a bit more focus and ease now that primary development has shifted back here.

Summary for the commit I added:

  1. Build was failing due to some formatting in the search: bit for 6 detections. The second line of these all used ' single quotes around fields which appeared to close the initial quote around the full search. The solution here was adding the > bracket to force the folded style of multiline string, and then indenting each of those blocks.
  2. Once those were finished, validate was able to run the actual validation checks against the rest of the fields. This raised a series of errors related to the tags.asset_type field, which we've adjusted from Office 365 to match the expected value of O365 Tenant.

As I'm writing this, unit testing is still running but the build steps have all passed! Hoping to get this merged for our next release!

Cheers!

@nterl0k
Copy link
Contributor Author

nterl0k commented Jul 24, 2024 via email

@ljstella ljstella self-requested a review July 24, 2024 22:14
@ljstella
Copy link
Contributor

Alright, testing now passes entirely for these. Before we merge, I think we just need to tweak the lookup definition & lookup filename so that on updates of the app to the version that include this, the new lookup is put in place. Other than that, we should be set to merge. Thank you @nterl0k !

ljstella
ljstella previously approved these changes Jul 25, 2024
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Thanks again @nterl0k for this awesome contribution!

@nterl0k
Copy link
Contributor Author

nterl0k commented Jul 25, 2024 via email

@ljstella ljstella modified the milestones: v4.37.0, v4.38.0 Jul 26, 2024
@ljstella ljstella self-requested a review August 7, 2024 18:52
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@patel-bhavin patel-bhavin merged commit 865d525 into splunk:develop Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants