Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splunk_Attack_Analyzer_Dynamic_Analysis_Fix_Bug #2756

Merged

Conversation

tccontre
Copy link
Contributor

@tccontre tccontre commented Jul 3, 2023

Details

What does this PR have in it? Screenshots are worth 1000 words 😄

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.

@kelby-shelton
Copy link
Contributor

LGTM

"connectorConfigs": [
"splunk_attack_analyzer"
"splunk attack analyzer app"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelby-shelton : shouldn't this have underscores?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't actually matter because the user will be prompted to map it to their own asset name before they save it locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeet! thanks for the clarification. We will release this in 4.12.0

@patel-bhavin patel-bhavin changed the base branch from develop to release_v4.12.0 September 12, 2023 19:47
@patel-bhavin patel-bhavin merged commit 64cf65a into release_v4.12.0 Sep 12, 2023
26 checks passed
@delete-merged-branch delete-merged-branch bot deleted the Splunk_Attack_Analyzer_Dynamic_Analysis_Fix_Bug branch September 12, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants