-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TR-2947] Active Directory Enable Account Dispatch #2740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P4T12ICK
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In Notes for the playbook is a small typo: Ulocking instead of Unlocking
- I'm not sure if the first if/else block with the condition artifact:*.cef.act is correct. When I added manually some user name as artifacts, it never executed. Maybe you can explain it to me.
- The generated note table has a small bug (see screenshot)
reviewed by Patrick! |
patel-bhavin
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please check all that apply:
Release Notes
Replace the following list with release notes that describe the high level components of the PR:
Playbook quality checklist
Please check if your PR fulfills the following requirements.
Requirements for Settings
Requirements for all playbooks
Requirements for all playbook blocks
Requirements for specific blocks
Action
Utility
Playbook
Requirements for specific playbooks
Other considerations (PR type specific)
Thanks for contributing!