Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TR-2947] Active Directory Enable Account Dispatch #2740

Merged
merged 70 commits into from
Aug 18, 2023
Merged

Conversation

ljstella
Copy link
Contributor

Pull Request Type

Please check all that apply:
  • New playbook
  • Bugfix
  • Feature add
  • Code style update (formatting, renaming)
  • Documentation
  • Other (please describe):

Release Notes

Replace the following list with release notes that describe the high level components of the PR:

Playbook quality checklist

Please check if your PR fulfills the following requirements.

Requirements for Settings

  • Playbook name is A-Z in Title case with underscores between words. (e.g. MS_Graph_Search_and_Purge)
  • Category in Title case with spaces between words (e.g. Identifier Reputation Analysis)
  • Description is free of grammatical errors and describe what the playbook does.
  • Notes list any setup required on the third-party API as well as intended areas for customization.
  • Label is set to '*'

Requirements for all playbooks

  • Playbook block count not greater than 15 (not including Start and End blocks).
  • No more than 3 branching paths.
  • If referencing a custom list, Notes document what the expected values are in that custom list.

Requirements for all playbook blocks

  • All blocks have a custom name no more than 4 words, all lowercase, and separated by space (e.g. close workbook task)
  • All blocks that support a Notes Tooltip have it filled out. Must be grammatically correct and describes the intended purpose of that block.
  • Where custom code is used, block notes indicate presence of custom code (e.g. "This block uses custom code")
  • No block is disabled by custom code
  • Custom code is documented with notes

Requirements for specific blocks

Action
  • Use apps available on Splunkbase
  • Use asset names that are the app name, all lowercase separated by underscores (e.g. Azure AD Graph becomes azure_ad_graph)
Utility
  • Block is using community version
Playbook
  • Block is using local version

Requirements for specific playbooks

Other considerations (PR type specific)

  • If new playbook, there is a screenshot ending in .png with the same name as the playbook .json
  • Playbook major minor version matches repo (e.g. 5.5 != 6.0)
  • PR contains both .py and .json

Thanks for contributing!

Copy link
Collaborator

@P4T12ICK P4T12ICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In Notes for the playbook is a small typo: Ulocking instead of Unlocking
  • I'm not sure if the first if/else block with the condition artifact:*.cef.act is correct. When I added manually some user name as artifacts, it never executed. Maybe you can explain it to me.
  • The generated note table has a small bug (see screenshot)

@P4T12ICK
Copy link
Collaborator

Screenshot 2023-06-27 at 10 21 44

@patel-bhavin
Copy link
Contributor

reviewed by Patrick!

@patel-bhavin patel-bhavin merged commit d0d0d7a into develop Aug 18, 2023
26 checks passed
@delete-merged-branch delete-merged-branch bot deleted the TR-2947 branch August 18, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants