Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade python3.9 for running appinspect cli #116

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dfederschmidt
Copy link

AppInspect v3.0.0 shows the following change:

Mainly, this means changing os.path.join() to any of its object-oriented alternative, e.g. pathlib.Path(). Refer to the official pathlib migration guide.

Now, the error I'm seeing is

      Check that all XML files are well-formed. 
          ERROR: 'PosixPath' object has no attribute 
              'getCharacterStream' 

Which leads me to believe that we're encountering this issue because the action runs the command with Python 3.7 and the fix for this issue only landed in 3.8.
Could it be that this makes appinspect-cli==3.0.0 partially incompatible with 3.7?

From what I've been seeing, the appinspect-cli command is independent of any Python version that Splunk uses, so we can upgrade the runtime to Python 3.9.

@artemrys I'm not sure how to upgrade the image path in lockstep with the release so marking this as a draft for now.
Also, I have not tested this change yet.

image: "docker://ghcr.io/splunk/appinspect-cli-action/appinspect-cli-action:v2.0.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant