chore: restructure code and add test cases #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
hetangmodi-crest
requested review from
artemrys,
sgoral-splunk and
kkedziak-splunk
4 tasks
lplonka-splunk
previously approved these changes
Sep 19, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [splunk/appinspect-cli-action](https://togithub.com/splunk/appinspect-cli-action) | action | minor | `v2.7` -> `v2.8` | --- ### Release Notes <details> <summary>splunk/appinspect-cli-action (splunk/appinspect-cli-action)</summary> ### [`v2.8`](https://togithub.com/splunk/appinspect-cli-action/compare/v2.7...v2.8) [Compare Source](https://togithub.com/splunk/appinspect-cli-action/compare/v2.7...v2.8) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every 2 weeks on Sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/splunk/addonfactory-ucc-generator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
**Issue number:** - ## Summary ### Changes > Fixed the indentation of unordered list used in the docs. ### User experience > No change, only the documentation would be changed, made prettier. ## Checklist If your change doesn't seem to apply, please leave them unchecked. * [ ] I have performed a self-review of this change * [ ] Changes have been tested * [x] Changes are documented * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/) Co-authored-by: Artem Rys <rysartem@gmail.com>
…oard (#1337) **Issue number: [ADDON-74234](https://splunk.atlassian.net/browse/ADDON-74234)** ## Summary Added possibility to display messages logged with CRITICAL level in the error section in the monitoring dashboard. ### Changes Global config -> dashboard has a new setting: `error_panel_log_lvl`, which allows the user to define what log level should be displayed in the errors section of the monitoring panel ### User experience The user can define error log lvl in the global config. By default only ERROR ## Checklist If your change doesn't seem to apply, please leave them unchecked. * [x] I have performed a self-review of this change * [x] Changes have been tested * [x] Changes are documented * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/) --------- Co-authored-by: Artem Rys <rysartem@gmail.com>
hetangmodi-crest
force-pushed
the
chore/restructure-code-test-case
branch
from
1229366
to
488e8d7
Compare
lplonka-splunk
approved these changes
Sep 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-73368
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.