Skip to content

Commit

Permalink
preparing 1.0.1
Browse files Browse the repository at this point in the history
  • Loading branch information
freekmurze committed Jan 19, 2016
1 parent 5c71d65 commit 0018d1b
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,11 @@

All Notable changes to `db-dumper` will be documented in this file

## 1.0.0 - YYYY-MM-DD
## 1.0.1 - 2016-01-19

- Fixed typo in `checkIfDumpWasSuccessFul`-method name
- Fixed bug running Process

## 1.0.0 - 2016-01-19

- Initial release
6 changes: 4 additions & 2 deletions src/Databases/MySql.php
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@ public function dumpToFile(string $dumpFile)

$command = $this->getDumpCommand($dumpFile, $temporaryCredentialsFile);

$process = (new Process($command))->run();
$process = new Process($command);

$this->checkIfDumpWasSuccessFull($process, $dumpFile);
$process->run();

$this->checkIfDumpWasSuccessFul($process, $dumpFile);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/DbDumper.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public static function create()
return new static();
}

protected function checkIfDumpWasSuccessFull(Process $process, string $outputFile) : bool
protected function checkIfDumpWasSuccessFul(Process $process, string $outputFile) : bool
{
if (!$process->isSuccessful()) {
throw DumpFailed::processDidNotEndSuccessfully($this->process);
Expand Down

0 comments on commit 0018d1b

Please sign in to comment.