Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json fields where applicable #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgordon16
Copy link

Resolves #298

@jheld
Copy link
Collaborator

jheld commented Jul 26, 2024

How well does the code work when querying rows after the migration goes through?

@sgordon16
Copy link
Author

I'm not sure I understand your question, but you can now do a query like this for example:

CRUDEvent.objects.filter(object_json_repr__0__model="app.user", changed_fields__has_key="name")

This will give you all the records of users that had their name changed.

@sgordon16
Copy link
Author

@jheld Just following up on this. Are there any issues with this?

@jheld
Copy link
Collaborator

jheld commented Aug 20, 2024

Probably not. but we are in the middle of a potential issue on the latest pre-release and I'm hesitant to add more big changes like this. I think 1.3.8 series would be a good fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use JSONField for object repr field
2 participants