Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marvell] platform renaming for innovium #3252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krismarvell
Copy link

What I did
asic type checks for marvell platforms renamed

  • innovium to marvell-teralynx
  • marvell to marvell-prestera

Why I did it
asictypes are being renamed in sonic-buildimage repo and hence respective platform checks needs changes in swss

How I verified it
Run sonic-ptf on ACL and PFC modules to make sure the change does not impact existing functionality

Details if related

@prsunny
Copy link
Collaborator

prsunny commented Sep 4, 2024

This seems to be a breaking change to me. Can you confirm if this can be merged and not break existing platform?

@krismarvell
Copy link
Author

@prsunny This PR wont break existing platform builds and also the functionalty of marvell(renamed as marvell-prestera) and innovium(renamed as marvell-teralynx) platforms. Also this has sonic-buildimage changes to enable respective platform builds in sonic master repo. Pls let me know if you see any specific concerns/breakages even with the additional changes in sonic-buildimage, sonic-sairedis and sonic-utilities PRs below.
sonic-buildimage: sonic-net/sonic-buildimage#19829
sonic-sairedis: sonic-net/sonic-sairedis#1408
sonic-utilties: sonic-net/sonic-utilities#3474

@krismarvell
Copy link
Author

krismarvell commented Sep 9, 2024

@prsunny I see code coverage failing. Is there a way to bypass vstest ? If not, may need your help as to how to trace the code coverage errors.

@krismarvell
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Sep 23, 2024

@krismarvell , we can merge this PR once you confirm its ready. Do you've an order of merge dependency? Which PR should be going first?

@krismarvell
Copy link
Author

@prsunny For the successful image build, i think it can be merged in any order and hence this swss change can be merged indepently. Pls let me know if you think otherwise. the sonic-swss submodule update into sonic-buildimage will happen subsequently ?

@prsunny
Copy link
Collaborator

prsunny commented Sep 23, 2024

@prsunny For the successful image build, i think it can be merged in any order and hence this swss change can be merged indepently. Pls let me know if you think otherwise. the sonic-swss submodule update into sonic-buildimage will happen subsequently ?

submodule update is automated. It can happen in the next day itself. Is it going to break anything for this platform?

@krismarvell
Copy link
Author

@prsunny this merge is not going to break the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants