[xcvrd] Add logs to improve debugging in xcvrd #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
prgeor
reviewed
Sep 19, 2024
sonic-xcvrd/xcvrd/xcvrd.py
Outdated
| @@ -440,6 +440,7 @@ def post_port_sfp_info_to_db(logical_port_name, port_mapping, table, transceiver | |||
| break | |||
|
|
|||
| if not _wrapper_get_presence(physical_port): | |||
| helper_logger.log_warning("Transceiver not present in port {}".format(logical_port_name)) | |||
There was a problem hiding this comment.
@mihirpat1 may be notice should be sufficient.
There was a problem hiding this comment.
@prgeor I have now modified it to notice.
prgeor
approved these changes
Sep 19, 2024
|
@bingwang-ms Can you please help to cherry-pick this to 202405 branch? |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Sep 20, 2024
* [xcvrd] Add logs to improve debugging in xcvrd Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Fixed unit-test failure * Improved code coverage * Changed warning to notice --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
Cherry-pick PR to 202405: #540 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 20, 2024
* [xcvrd] Add logs to improve debugging in xcvrd Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Fixed unit-test failure * Improved code coverage * Changed warning to notice --------- Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following logs are planned to be added to xcvrd for enhancing debuggability
sonic-platform-daemons/sonic-xcvrd/xcvrd/xcvrd.py
Line 1382 in f581c06
sonic-platform-daemons/sonic-xcvrd/xcvrd/xcvrd.py
Lines 442 to 443 in f581c06
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)
MSFT ADO - 29427847