Fix NumRegField byte(s) read #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andywongarista can you review this fix |
AnoopKamath
reviewed
Aug 10, 2023
| @@ -86,6 +87,7 @@ def __init__(self, name, bitpos, offset=None, **kwargs): | |||
| super(RegBitField, self).__init__(name, offset, **kwargs) | |||
| assert bitpos < 64 | |||
| self.bitpos = bitpos | |||
| self.bitmask = 1 << self.bitpos | |||
There was a problem hiding this comment.
Are we using bitmask in RegBitField ?
There was a problem hiding this comment.
@andywongarista not directly, but when RegBitField is grouped inside a NumberRegField or CodeRegField
AnoopKamath
approved these changes
Aug 11, 2023
yxieca
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NumRegField read worked fine when the fields were single bit. Now that we have RegBitsFields with multiple bits we need to adjust the mask accordingly.
Motivation and Context
NumRegFields having RegBitsFields did not read the byte correctly. This is now fixed with this change.
How Has This Been Tested?
Unit test passed
Additional Information (Optional)